Github user MechCoder commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7554#discussion_r35239289
  
    --- Diff: python/pyspark/mllib/linalg.py ---
    @@ -1152,9 +1156,385 @@ def sparse(numRows, numCols, colPtrs, rowIndices, 
values):
             return SparseMatrix(numRows, numCols, colPtrs, rowIndices, values)
     
     
    +class DistributedMatrix(object):
    +    """Represents a distributively stored matrix backed by one or more 
RDDs."""
    +    def numRows(self):
    --- End diff --
    
    If you would like to represent this as an abstract class, it might be 
better to use `ABCMeta` and `abstract method` from `abc` module. Check out 
`pyspark/ml/pipeline.py`
    
    One quick advantage that I can recall from memory is that an error is 
raised during object creation rather than when the methods are called as it 
does now. (I think)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to