Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7480#discussion_r35249350
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastLeftSemiJoinHash.scala
---
@@ -40,15 +40,14 @@ case class BroadcastLeftSemiJoinHash(
val buildIter = right.execute().map(_.copy()).collect().toIterator
if (condition.isEmpty) {
- // rowKey may be not serializable (from codegen)
- val hashSet = buildKeyHashSet(buildIter, copy = true)
+ val hashSet = buildKeyHashSet(buildIter)
--- End diff --
Orthogonal to this patch, we should work on removing
BroadcastLeftSemiJoinHash, and just use an equi-join. Otherwise we have too
many paths we need to optimize for.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
