Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7480#discussion_r35257490
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastNestedLoopJoin.scala
---
@@ -127,8 +138,10 @@ case class BroadcastNestedLoopJoin(
while (i < rel.length) {
if (!allIncludedBroadcastTuples.contains(i)) {
(joinType, buildSide) match {
- case (RightOuter | FullOuter, BuildRight) => buf += new
JoinedRow(leftNulls, rel(i))
- case (LeftOuter | FullOuter, BuildLeft) => buf += new
JoinedRow(rel(i), rightNulls)
+ case (RightOuter | FullOuter, BuildRight) =>
--- End diff --
would be great to move this branches outside the while loop, rather than
testing them in the loop
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
