Github user massie commented on the pull request:

    https://github.com/apache/spark/pull/7403#issuecomment-123917486
  
    This is ready for review when someone has the time. All unit tests pass.
    
    * Only classes marked `@DeveloperApi` or are `private[spark]` have been 
altered to include ClassTags (breaking compatibility)
    * The `PairRRDFunctions` have three new `sortByKeyWithClassTag` methods 
that mirror the original `sortByKey` signatures
    * All calls to `sortByKey` have been moved to `sortByKeyWithClassTag`. Only 
users that call `sortByKey` directly will not have combiner class type 
information provided to the shuffle. 
    * I've added a warning message when `sortByKey` is used
    * As an aside, I wrote the code to use the `implicit` trick I talked about 
and it turned out to complicate the code quite a lot.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to