Github user massie commented on a diff in the pull request:
https://github.com/apache/spark/pull/7403#discussion_r35395219
--- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala
---
@@ -103,13 +105,42 @@ class PairRDDFunctions[K, V](self: RDD[(K, V)])
}
/**
- * Simplified version of combineByKey that hash-partitions the output
RDD.
+ * Use [[combineByKeyWithClassTag]] instead.
+ */
+ def combineByKey[C](createCombiner: V => C,
+ mergeValue: (C, V) => C,
+ mergeCombiners: (C, C) => C,
+ partitioner: Partitioner,
+ mapSideCombine: Boolean = true,
+ serializer: Serializer = null): RDD[(K, C)] = {
+ log.warn("Running combineByKey. Shuffle will not have combine value
ClassTag. " +
--- End diff --
Agree. I'll update this to remove the warning message and revert the
documentation.
Shuffle managers that don't depend on having a defined combiner class can
throw an error, log a warning, etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
