Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/5748#issuecomment-124298189
It looks good, just tiny comments. We can make sure this gets into 1.5.
> However, if the user provides a Word2Vec map by himself to construct the
Word2Vec model (in the future, since Word2Vec model is marked as
private[mllib]), it creates a huge array of size numWords * numDims. Are we
okay with that?
I think that's OK, though we could make that constructor public in the
future. I think it would only be useful if someone wanted to load a model
(created by another library) into MLlib.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
