Github user davies commented on the pull request:
https://github.com/apache/spark/pull/7592#issuecomment-124409560
@rxin What's the advantage of unsafe provided but missing in this
approach? And what's the `quite a bit of conversions` that could be avoid with
new unsafe join operator?
The broadcast is shared by threads, it's good by design. Is there any other
better not-shared way to do this? I did not figured out, please explain a
little bit more.
I remembered that we had talked about that we should re-use the code for
both safe and unsafe join, this is the thing that could meet the expectation.
cc @marmbrus
If you still have concern on this, do NOT hurry to merge it. Please feel
free to sending out another way-better PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
