Github user witgo commented on a diff in the pull request:

    https://github.com/apache/spark/pull/921#discussion_r13425322
  
    --- Diff: 
yarn/stable/src/main/scala/org/apache/spark/deploy/yarn/ExecutorLauncher.scala 
---
    @@ -204,9 +204,17 @@ class ExecutorLauncher(args: 
ApplicationMasterArguments, conf: Configuration, sp
         // TODO: Handle container failure
     
         yarnAllocator.addResourceRequests(args.numExecutors)
    -    while ((yarnAllocator.getNumExecutorsRunning < args.numExecutors) && 
(!driverClosed)) {
    +    val startTime = System.currentTimeMillis()
    +    var usedTime = 0L
    +    while (((yarnAllocator.getNumExecutorsRunning < args.numExecutors) && 
(!driverClosed))
    +      && (usedTime < 1000L * 60 * 10)) {
           yarnAllocator.allocateResources()
    +      val numExecutorsFailed = yarnAllocator.getNumExecutorsFailed
    --- End diff --
    
    @tgravescs   
    Here also add the following code?
    ```
        if (yarnAllocator.getNumExecutorsFailed >= maxNumExecutorFailures) {
          finishApplicationMaster(FinalApplicationStatus.FAILED,
            "max number of executor failures reached")
        }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to