Github user witgo commented on a diff in the pull request:
https://github.com/apache/spark/pull/921#discussion_r13474143
--- Diff:
yarn/stable/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -252,16 +252,12 @@ class ApplicationMaster(args:
ApplicationMasterArguments, conf: Configuration,
try {
logInfo("Allocating " + args.numExecutors + " executors.")
// Wait until all containers have finished
- // TODO: This is a bit ugly. Can we make it nicer?
- // TODO: Handle container failure
yarnAllocator.addResourceRequests(args.numExecutors)
// Exits the loop if the user thread exits.
while (yarnAllocator.getNumExecutorsRunning < args.numExecutors &&
userThread.isAlive) {
- if (yarnAllocator.getNumExecutorsFailed >= maxNumExecutorFailures)
{
- finishApplicationMaster(FinalApplicationStatus.FAILED,
- "max number of executor failures reached")
- }
yarnAllocator.allocateResources()
+ checkNumExecutorsFailed()
+ allocateMissingExecutor()
--- End diff --
I think that only after the call
`yarnAllocator.allocateResources()`,`yarnAllocator.getNumExecutorsFailed `
value will change.
This is appropriate: after changing the value of
`yarnAllocator.getNumExecutorsFailed `, immediately call
`checkNumExecutorsFailed`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
