Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/7710#discussion_r35674198
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SparkPlanTest.scala ---
@@ -98,7 +100,7 @@ class SparkPlanTest extends SparkFunSuite {
planFunction: Seq[SparkPlan] => SparkPlan,
expectedAnswer: Seq[Row],
sortAnswers: Boolean = true): Unit = {
- SparkPlanTest.checkAnswer(input, planFunction, expectedAnswer,
sortAnswers) match {
+ SparkPlanTest.checkAnswer(input, planFunction, expectedAnswer,
sortAnswers, sqlContext) match {
--- End diff --
This is minor, and does not have to be addressed in this PR, but why did we
make that an `object`? It seems like this just complicates function calls
since now we can't access fields like the `sqlContext`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
