Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7710#discussion_r35674361
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/ScriptTransformation.scala
 ---
    @@ -68,9 +71,44 @@ case class ScriptTransformation(
           val errorStream = proc.getErrorStream
           val reader = new BufferedReader(new InputStreamReader(inputStream))
     
    -      val (outputSerde, outputSoi) = ioschema.initOutputSerDe(output)
    +      // TODO make the 2048 configurable?
    --- End diff --
    
    I don't mind cleaning up these comments; it might also be nice to edit some 
of the other comments to refer to the relevant JIRAs, since the code movement 
here makes it a bit harder to find them using `git blame`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to