Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/993#discussion_r13479735
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/dataTypes.scala
---
@@ -33,6 +33,13 @@ abstract class DataType {
case object NullType extends DataType
+object NativeType {
+ def all = Seq(
+ IntegerType, BooleanType, LongType, DoubleType, FloatType, ShortType,
ByteType, StringType)
+
+ def unapply(dt: DataType): Boolean = all.contains(dt)
--- End diff --
Is this used for pattern matching? I think it'd be easier to understand to
readers if it has a name like "isNativeType(tpe)" rather than NativeType(tpe)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
