Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7754#discussion_r35820858
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -639,6 +640,23 @@ object HiveTypeCoercion {
}
/**
+ * Turns Add/Subtract of DateType/TimestampType and CalendarIntervalType
to TimeAdd/TimeSub
+ */
+ object DateTimeOperations extends Rule[LogicalPlan] {
+ def apply(plan: LogicalPlan): LogicalPlan = plan
transformAllExpressions {
+ // Skip nodes who's children have not been resolved yet.
+ case e if !e.childrenResolved => e
+
+ case Add(l @ CalendarIntervalType(), r) if r.dataType !=
CalendarIntervalType =>
+ Cast(TimeAdd(Cast(r, TimestampType), l), r.dataType)
--- End diff --
my comment disappeared since this part changed, so posting again.
we should avoid implicitly casting any type -- just do it for
string/timestamp/date.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
