Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7754#discussion_r35821191
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -639,6 +640,27 @@ object HiveTypeCoercion {
}
/**
+ * Turns Add/Subtract of DateType/TimestampType/StringType and
CalendarIntervalType
+ * to TimeAdd/TimeSub
+ */
+ object DateTimeOperations extends Rule[LogicalPlan] {
--- End diff --
can you add a unit test for this rule?
make sure there is one test case just for this rule, and another that tests
DateTimeOperations and ImplicitTypeCasts in combination to make sure they still
work. I worry if we change ImplicitTypeCasts in the future, DateTimeOperations
might break (e.g. the interval got converted to string type)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
