Github user rekhajoshm commented on the pull request:
https://github.com/apache/spark/pull/7602#issuecomment-126163542
Thanks for your comment @srowen . It does not make it worse, as toString()
was in earlier code and was always doing it in addition to string objects in
recursive calls.However its a valid point you make, that is not needed, updated
.If you have a load testing environment where you could execute different
complexity of jobs in loops and check profiler with this branch, you will
conclude this helps.
imo OOM can never be completely solvable, as a users can run with
infinitely tight resource with extremely unreasonable job, but reducing those
probabilities is still essential.
Given that, please review , approve @srowen @JoshRosen @andrewor14 thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
