Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/7602#issuecomment-126272557
I was thinking that it required more memory because, indeed, the same
`String`s are being constructed and returned, but now a `StringBuilder` is
being build in parallel. I don't know for sure; I didn't measure it. In any
event, yes the idea is to only construct the result in a `StringBuilder`.
Does `makeDotSubgraph` need to return anything? right now it looks like the
recursive calls append to the result, but then return the current result to be
appended to itself in the caller? I could be reading it wrong but that doesn't
look right.
Also the initial argument starts with `" "` appended but I don't think
the original version started this way?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
