Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/7648#discussion_r35904605
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/rate/RateEstimator.scala
---
@@ -48,12 +49,21 @@ object RateEstimator {
/**
* Return a new RateEstimator based on the value of
`spark.streaming.RateEstimator`.
*
- * @return None if there is no configured estimator, otherwise an
instance of RateEstimator
+ * The only known estimator right now is `pid`.
+ *
+ * @return An instance of RateEstimator
* @throws IllegalArgumentException if there is a configured
RateEstimator that doesn't match any
* known estimators.
*/
- def create(conf: SparkConf): Option[RateEstimator] =
- conf.getOption("spark.streaming.backpressure.rateEstimator").map {
estimator =>
- throw new IllegalArgumentException(s"Unkown rate estimator:
$estimator")
+ def create(conf: SparkConf, batchInterval: Duration): RateEstimator =
+ conf.get("spark.streaming.backpressure.rateEstimator", "pid") match {
+ case "pid" =>
+ val proportional =
conf.getDouble("spark.streraming.backpressure.pid.proportional", -1.0)
--- End diff --
typo!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
