Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7770#discussion_r35905903
--- Diff:
core/src/main/java/org/apache/spark/shuffle/unsafe/UnsafeShuffleExternalSorter.java
---
@@ -86,6 +86,9 @@
private final LinkedList<SpillInfo> spills = new LinkedList<SpillInfo>();
+ // Peak memory used by this sorter, set immediately before each spill
--- End diff --
What if we never spill? In that case, will we report the peak memory usage
as zero?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
