Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7770#discussion_r35906939
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/ShuffleMapTask.scala ---
@@ -69,7 +72,13 @@ private[spark] class ShuffleMapTask(
val manager = SparkEnv.get.shuffleManager
writer = manager.getWriter[Any, Any](dep.shuffleHandle, partitionId,
context)
writer.write(rdd.iterator(partition,
context).asInstanceOf[Iterator[_ <: Product2[Any, Any]]])
- return writer.stop(success = true).get
+ writer match {
+ case unsafe: UnsafeShuffleWriter[_, _] =>
--- End diff --
I guess we don't need to necessarily worry about the writer task failing
due to an OutOfMemoryException because that will kill the executor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
