Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7771#discussion_r35914268
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/feature/OneHotEncoder.scala ---
    @@ -56,17 +56,26 @@ class OneHotEncoder(override val uid: String) extends 
Transformer
         new BooleanParam(this, "dropLast", "whether to drop the last category")
       setDefault(dropLast -> true)
     
    +  /**
    +   * Param for the output attr prefix. If not specified, a prefix will be 
automatically generated.
    +   * @group param
    +   */
    +  final val outputAttrPrefix: Param[String] =
    --- End diff --
    
    We try to keep ML attributes handling under the hood. So this parameter 
might be surprising to many users. Maybe we don't need to keep prefix and 
`_is_` in the generated feature names. Instead of "country_is_US`, we can have 
just `US` as the feature name, but under group `country` or whatever the output 
column names is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to