Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7771#discussion_r35914262
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/attribute/AttributeGroup.scala ---
@@ -165,6 +165,11 @@ class AttributeGroup private (
/** Converts to a StructField. */
def toStructField(): StructField = toStructField(Metadata.empty)
+ override def toString: String = {
--- End diff --
Is it required? Please keep this PR minimal. You can create another PR if
`toString` is useful for AttributeGroup. (Btw, we can reuse the JSON
serialization in `toString`.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
