Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7796#discussion_r35962670
  
    --- Diff: 
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/DirectKafkaInputDStream.scala
 ---
    @@ -73,12 +73,19 @@ class DirectKafkaInputDStream[
     
       protected val kc = new KafkaCluster(kafkaParams)
     
    -  protected val maxMessagesPerPartition: Option[Long] = {
    -    val ratePerSec = context.sparkContext.getConf.getInt(
    +  private val ratePerSec: Int = context.sparkContext.getConf.getInt(
           "spark.streaming.kafka.maxRatePerPartition", 0)
    -    if (ratePerSec > 0) {
    +  protected def maxMessagesPerPartition: Option[Long] = {
    +    val estimatedRate = 
rateController.map(_.getLatestRate().toInt).getOrElse(-1)
    --- End diff --
    
    I am not getting this. How does this work? Unless you define a rate 
controller in this class, wont it just inherit the InputDStream.rateController 
which is None?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to