Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/7829#issuecomment-126762684
Hmm, I don't think this is right. Quoting on Windows is completely
different from bash. What you're doing here is just changing the way the quoted
string is wrapped, but not changing the quoting itself. That will only work for
strings that do not have any characters that need to be quotes.
On top of that, if you quote a string on Windows when it doesn't need to be
quoted, Windows does not strip the quotes from it (aren't batch scripts
awesome?).
For an example of quoting on Windows, see:
https://github.com/apache/spark/blob/3697232b7d438979cc119b2a364296b0eec4a16a/launcher/src/main/java/org/apache/spark/launcher/CommandBuilderUtils.java#L262
So, even though I don't have a YARN-on-Windows install I can even try this
on, I'm pretty sure it doesn't work for anything but the simplest use cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
