Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/7770#issuecomment-127077143
Review status: 31 of 49 files reviewed at latest revision, 14 unresolved
discussions, some commit checks failed.
---
<sup>**[core/src/main/java/org/apache/spark/shuffle/unsafe/UnsafeShuffleWriter.java,
line 455
\[r11\]](https://reviewable.io:443/reviews/apache/spark/7770#-JvjyFnipw8r_uM6llmJ)**
([raw
file](https://github.com/apache/spark/blob/6aa2f7a8c2f4eb1de6281593326dce5a92d5c1e3/core/src/main/java/org/apache/spark/shuffle/unsafe/UnsafeShuffleWriter.java#L455)):</sup>
Done.
---
<sup>**[core/src/main/java/org/apache/spark/shuffle/unsafe/UnsafeShuffleWriter.java,
line 459
\[r11\]](https://reviewable.io:443/reviews/apache/spark/7770#-JvjySxUYG3yq_glTmT-)**
([raw
file](https://github.com/apache/spark/blob/6aa2f7a8c2f4eb1de6281593326dce5a92d5c1e3/core/src/main/java/org/apache/spark/shuffle/unsafe/UnsafeShuffleWriter.java#L459)):</sup>
you're right, I removed this conversion
---
<sup>**[core/src/main/scala/org/apache/spark/Accumulators.scala, line 157
\[r11\]](https://reviewable.io:443/reviews/apache/spark/7770#-Jvjz0QAGo9oQR2jYhzP)**
([raw
file](https://github.com/apache/spark/blob/6aa2f7a8c2f4eb1de6281593326dce5a92d5c1e3/core/src/main/scala/org/apache/spark/Accumulators.scala#L157)):</sup>
Done.
---
<sup>**[core/src/main/scala/org/apache/spark/Accumulators.scala, line 264
\[r11\]](https://reviewable.io:443/reviews/apache/spark/7770#-JvjzLl6KJl6UVVA1CmA)**
([raw
file](https://github.com/apache/spark/blob/6aa2f7a8c2f4eb1de6281593326dce5a92d5c1e3/core/src/main/scala/org/apache/spark/Accumulators.scala#L264)):</sup>
actually it would not compile, see comment below
---
<sup>**[core/src/main/scala/org/apache/spark/Accumulators.scala, line 268
\[r11\]](https://reviewable.io:443/reviews/apache/spark/7770#-JvjzK9DHuqJ_ogH2Wg4)**
([raw
file](https://github.com/apache/spark/blob/6aa2f7a8c2f4eb1de6281593326dce5a92d5c1e3/core/src/main/scala/org/apache/spark/Accumulators.scala#L268)):</sup>
It turns out scala thinks I'm reassigning a val if I do `internal = false`
here.
---
<sup>**[core/src/main/scala/org/apache/spark/scheduler/Stage.scala, line 78
\[r11\]](https://reviewable.io:443/reviews/apache/spark/7770#-Jvk-IpC7oolKQcwsJeO)**
([raw
file](https://github.com/apache/spark/blob/6aa2f7a8c2f4eb1de6281593326dce5a92d5c1e3/core/src/main/scala/org/apache/spark/scheduler/Stage.scala#L78)):</sup>
Done.
---
<sup>**[core/src/main/scala/org/apache/spark/TaskContext.scala, line 65
\[r11\]](https://reviewable.io:443/reviews/apache/spark/7770#-Jvk-YWmoTLAUs2KfDN3)**
([raw
file](https://github.com/apache/spark/blob/6aa2f7a8c2f4eb1de6281593326dce5a92d5c1e3/core/src/main/scala/org/apache/spark/TaskContext.scala#L65)):</sup>
Done.
---
<sup>**[core/src/main/scala/org/apache/spark/TaskContext.scala, line 67
\[r11\]](https://reviewable.io:443/reviews/apache/spark/7770#-Jvk-blSJZ0ZULb49BEx)**
([raw
file](https://github.com/apache/spark/blob/6aa2f7a8c2f4eb1de6281593326dce5a92d5c1e3/core/src/main/scala/org/apache/spark/TaskContext.scala#L67)):</sup>
Weird, it went away. I made this `private[spark]`
---
<sup>**[core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala, line
72
\[r11\]](https://reviewable.io:443/reviews/apache/spark/7770#-JvVHinLLknE441mhOf0-r11-72)**
([raw
file](https://github.com/apache/spark/blob/6aa2f7a8c2f4eb1de6281593326dce5a92d5c1e3/core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala#L72)):</sup>
The issue is that we don't track all SQL operators (e.g. normal non-unsafe
in-memory Sort). It would be misleading if Sort ends up having lower "peak
execution memory" than UnsafeExternalSort. Let's move this discussion to the
main thread.
---
<sup>**[core/src/main/scala/org/apache/spark/ui/ToolTips.scala, line 70
\[r11\]](https://reviewable.io:443/reviews/apache/spark/7770#-JvVHinLLknE441mhOf--r11-70)**
([raw
file](https://github.com/apache/spark/blob/6aa2f7a8c2f4eb1de6281593326dce5a92d5c1e3/core/src/main/scala/org/apache/spark/ui/ToolTips.scala#L70)):</sup>
There is not a great name for "aggregation + shuffle + join". Elsewhere in
Spark we actually incorrectly use "spark.shuffle.memoryFraction" for
non-shuffle operations, simply because there is not a more general category.
I'm not a die-hard fan of "execution memory" either, but it's the best I can
come up with.
---
<sup>**[sql/core/src/main/scala/org/apache/spark/sql/execution/sort.scala,
line 81
\[r1\]](https://reviewable.io:443/reviews/apache/spark/7770#-JvVHinQX4wFdRHT7yOV-r1-83)**
([raw
file](https://github.com/apache/spark/blob/5b5e6f36b8a0e37f1953e12c438e01c58872e5fa/sql/core/src/main/scala/org/apache/spark/sql/execution/sort.scala#L81)):</sup>
Done.
---
<sup>**[sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala,
line 1621
\[r11\]](https://reviewable.io:443/reviews/apache/spark/7770#-Jvk1l80_3dvUKbI95U6)**
([raw
file](https://github.com/apache/spark/blob/6aa2f7a8c2f4eb1de6281593326dce5a92d5c1e3/sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala#L1621)):</sup>
Done.
---
Comments from the [review on
Reviewable.io](https://reviewable.io:443/reviews/apache/spark/7770)
<!-- Sent from Reviewable.io -->
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
