Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/7770#discussion_r36049009
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala ---
@@ -67,6 +68,8 @@ private[ui] class StagePage(parent: StagesTab) extends
WebUIPage("stage") {
// if we find that it's okay.
private val MAX_TIMELINE_TASKS =
parent.conf.getInt("spark.ui.timeline.tasks.maximum", 1000)
+ private val displayPeakExecutionMemory =
+ parent.conf.getOption("spark.sql.unsafe.enabled").exists(_.toBoolean)
--- End diff --
The issue is that we don't track all SQL operators (e.g. normal non-unsafe
in-memory Sort). It would be misleading if Sort ends up having lower "peak
execution memory" than UnsafeExternalSort. Let's move this discussion to the
main thread.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
