Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/921#discussion_r13557054
--- Diff:
yarn/stable/src/main/scala/org/apache/spark/deploy/yarn/ExecutorLauncher.scala
---
@@ -200,17 +200,24 @@ class ExecutorLauncher(args:
ApplicationMasterArguments, conf: Configuration, sp
logInfo("Allocating " + args.numExecutors + " executors.")
// Wait until all containers have finished
- // TODO: This is a bit ugly. Can we make it nicer?
- // TODO: Handle container failure
-
yarnAllocator.addResourceRequests(args.numExecutors)
while ((yarnAllocator.getNumExecutorsRunning < args.numExecutors) &&
(!driverClosed)) {
yarnAllocator.allocateResources()
+ allocateMissingExecutor()
--- End diff --
can you change this to have similar logic - allocate outside loop, then
inside loop add missing and then allocate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
