Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7882#discussion_r36054584
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
 ---
    @@ -562,6 +562,12 @@ object HiveTypeCoercion {
               case Some(finalDataType) => Coalesce(es.map(Cast(_, 
finalDataType)))
               case None => c
             }
    +
    +      case n @ NaNvl(l, r) if l.dataType != r.dataType =>
    +        l.dataType match {
    +          case DoubleType => NaNvl(l, Cast(r, DoubleType))
    +          case FloatType => NaNvl(Cast(l, DoubleType), r)
    --- End diff --
    
    could this throw a bad exception if the input is some other type that is 
not Double/Float?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to