Github user yjshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7882#discussion_r36055388
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -227,6 +227,7 @@ abstract class BinaryComparison extends BinaryOperator
with Predicate {
override def genCode(ctx: CodeGenContext, ev: GeneratedExpressionCode):
String = {
if (ctx.isPrimitiveType(left.dataType)
+ && left.dataType != BooleanType // java boolean doesn't support >
or < operator
--- End diff --
yes, but without test against `BooleanType`, it would use
```scala
// faster version
defineCodeGen(ctx, ev, (c1, c2) => s"$c1 $symbol $c2")
```
rather than the else part, therefore, `genComp` is not used.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
