Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/7886#issuecomment-127402968
One high-level comment: unless I've overlooked it, there doesn't seem to be
any documentation in the code to explain what the `nullSafe` concept means
here, although maybe the meaning is clear from usage and context. One
potential area of naming confusion is the fact that we use "null safety" when
talking about whether expression evaluation methods can expect to receive null
values or not. Our usage here seems slightly backwards almost, though, since
it seems like this PR says that a null-_safe_ partitioning means that the nulls
will be shuffled, whereas the unsafe version drops the nulls. Am I overlooking
something or is this potentially confusing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
