Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7886#discussion_r36130517
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala ---
    @@ -170,14 +170,57 @@ class PlannerSuite extends SparkFunSuite with 
SQLTestUtils {
     
           // Disable broadcast join
           withSQLConf(SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> "-1") {
    +        val joins = Array("JOIN", "LEFT OUTER JOIN", "RIGHT OUTER JOIN", 
"FULL OUTER JOIN")
    +        var i = 0
    +        while (i < joins.length) {
    --- End diff --
    
    Why did you use a `while` loop here instead of a `for` comprehension or 
pair of nested for loops?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to