Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7447#discussion_r36261104
  
    --- Diff: 
mllib/src/test/scala/org/apache/spark/ml/classification/DecisionTreeClassifierSuite.scala
 ---
    @@ -232,6 +232,13 @@ class DecisionTreeClassifierSuite extends 
SparkFunSuite with MLlibTestSparkConte
         compareAPIs(rdd, dt, categoricalFeatures = Map.empty[Int, Int], 
numClasses)
       }
     
    +  test("copied model must have the same parent") {
    --- End diff --
    
    True, that's a good point.  I'm OK with you leaving them as separate tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to