GitHub user vanzin opened a pull request:

    https://github.com/apache/spark/pull/7970

    [SPARK-9651] Fix UnsafeExternalSorterSuite.

    First, it's probably a bad idea to call generated Scala methods
    from Java. In this case, the method being called wasn't actually
    "Utils.createTempDir()", but actually the method that returns the
    first default argument to the actual createTempDir method, which
    is just the location of java.io.tmpdir; meaning that all tests in
    the class were using the same temp dir, and thus affecting each
    other.
    
    Second, spillingOccursInResponseToMemoryPressure was not writing
    enough records to actually cause a spill.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vanzin/spark SPARK-9651

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/7970.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #7970
    
----
commit a64f36a13f5ee6cdeaa09f65e55b8a08bd0936b2
Author: Marcelo Vanzin <[email protected]>
Date:   2015-08-05T19:18:20Z

    [SPARK-9651] Fix UnsafeExternalSorterSuite.
    
    First, it's probably a bad idea to call generated Scala methods
    from Java. In this case, the method being called wasn't actually
    "Utils.createTempDir()", but actually the method that returns the
    first default argument to the actual createTempDir method, which
    is just the location of java.io.tmpdir; meaning that all tests in
    the class were using the same temp dir, and thus affecting each
    other.
    
    Second, spillingOccursInResponseToMemoryPressure was not writing
    enough records to actually cause a spill.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to