Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7970#discussion_r36345125
  
    --- Diff: 
core/src/test/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorterSuite.java
 ---
    @@ -101,7 +101,7 @@ public OutputStream apply(OutputStream stream) {
       public void setUp() {
         MockitoAnnotations.initMocks(this);
         sparkConf = new SparkConf();
    -    tempDir = new File(Utils.createTempDir$default$1());
    +    tempDir = Utils.createTempDir(System.getProperty("java.io.tmpdir"), 
"unsafe-test");
    --- End diff --
    
    Oh right it makes a subdir every time anyway. Well, it'd be better to clean 
up the temp dir in `tearDown` if possible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to