Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8029#discussion_r36534463
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -137,8 +137,7 @@ class CodeGenContext {
dataType match {
case _ if isPrimitiveType(jt) =>
s"$row.set${primitiveTypeName(jt)}($ordinal, $value)"
case t: DecimalType => s"$row.setDecimal($ordinal, $value,
${t.precision})"
- // The UTF8String may came from UnsafeRow, otherwise clone is cheap
(re-use the bytes)
- case StringType => s"$row.update($ordinal, $value.clone())"
+ case StringType => s"$row.update($ordinal, $value)"
--- End diff --
This could be used in generated MutableProjection, so we need the copy()
here, or we should make sure that UnsafeRow will not be used with
MutableProjection (the fallback version of new aggregation)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
