Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/8029#discussion_r36574698
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -137,8 +137,7 @@ class CodeGenContext {
dataType match {
case _ if isPrimitiveType(jt) =>
s"$row.set${primitiveTypeName(jt)}($ordinal, $value)"
case t: DecimalType => s"$row.setDecimal($ordinal, $value,
${t.precision})"
- // The UTF8String may came from UnsafeRow, otherwise clone is cheap
(re-use the bytes)
- case StringType => s"$row.update($ordinal, $value.clone())"
+ case StringType => s"$row.update($ordinal, $value)"
--- End diff --
SafeProjection may be not the only one projection that turn an UnsafeRow
into InternalRow. For some operators that accept both safe row and unsafe row,
that will use generated mutable projection, it will got crupted UTF8String if
we remove the copy here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
