Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8038#discussion_r36684178
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregationIterator.scala
---
@@ -334,7 +334,7 @@ class TungstenAggregationIterator(
// This is the hash map used for hash-based aggregation. It is backed by
an
// UnsafeFixedWidthAggregationMap and it is used to store
// all groups and their corresponding aggregation buffers for hash-based
aggregation.
- private[this] val hashMap = new UnsafeFixedWidthAggregationMap(
+ private[aggregate] val hashMap = new UnsafeFixedWidthAggregationMap(
--- End diff --
If we change it to `private[aggregate]`, looks like we will lose the direct
field access of `hashMap` (provided by `private[this]`). How about we create a
method to return `hashMap` instead of changing the scope.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
