Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8038#discussion_r36686460
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregationIteratorSuite.scala
---
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.aggregate
+
+import org.apache.spark._
+import org.apache.spark.sql.catalyst.expressions._
+import org.apache.spark.unsafe.memory.TaskMemoryManager
+import
org.apache.spark.sql.catalyst.expressions.InterpretedMutableProjection
+
+class TungstenAggregationIteratorSuite extends SparkFunSuite with
LocalSparkContext {
+
+ test("memory acquired on construction") {
+ // Needed for various things in SparkEnv
+ sc = new SparkContext("local", "testing")
+ val taskMemoryManager = new
TaskMemoryManager(sc.env.executorMemoryManager)
+ val taskContext = new TaskContextImpl(0, 0, 0, 0, taskMemoryManager,
null, Seq.empty)
+ TaskContext.setTaskContext(taskContext)
+
+ // Assert that a page is allocated before processing starts
+ var iter: TungstenAggregationIterator = null
+ try {
+ val newMutableProjection = (expr: Seq[Expression], schema:
Seq[Attribute]) => {
+ () => new InterpretedMutableProjection(expr, schema)
+ }
+ iter = new TungstenAggregationIterator(
+ Seq.empty, Seq.empty, Seq.empty, 0, Seq.empty,
newMutableProjection, Seq.empty, None)
+ val numPages = iter.hashMap.getNumDataPages
+ assert(numPages === 1)
+ } finally {
+ // Clean up
+ if (iter != null) {
+ iter.free()
+ }
+ TaskContext.unset()
--- End diff --
this extends `LocalSparkContext`, which does that for us
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
