Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/8068#discussion_r36713622
--- Diff: core/src/main/java/org/apache/spark/util/collection/TimSort.java
---
@@ -914,7 +915,7 @@ private void mergeHi(int base1, int len1, int base2,
int len2) {
* @param minCapacity the minimum required capacity of the tmp array
* @return tmp, whether or not it grew
*/
- private Buffer ensureCapacity(int minCapacity) {
+ private Buffer ensureCapacity(int minCapacity) throws IOException {
--- End diff --
I use `IOException` because in some existing methods that do similar thing
`IOException` is thrown instead of `OutOfMemoryError`. E.g.,
`UnsafeExternalSorter`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
