Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/7447#discussion_r36779920
--- Diff: mllib/src/test/scala/org/apache/spark/ml/PipelineSuite.scala ---
@@ -92,6 +93,7 @@ class PipelineSuite extends SparkFunSuite {
val copied = model.copy(ParamMap(hashingTF.numFeatures -> 10))
require(copied.stages(0).asInstanceOf[HashingTF].getNumFeatures === 10,
"copy should handle extra stage params")
+ MLTestingUtils.checkCopy(model)
--- End diff --
This should be in a different test. The model should be produced via
fit(), not constructed from scratch, so that the model has a parent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
