Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/7447#discussion_r36779944
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tuning/CrossValidatorSuite.scala ---
@@ -111,6 +112,22 @@ class CrossValidatorSuite extends SparkFunSuite with
MLlibTestSparkContext {
cv.validateParams()
}
}
+
+ test("copied model must have the same parent") {
+ val lr = new LogisticRegression
+ val lrParamMaps = new ParamGridBuilder()
+ .addGrid(lr.regParam, Array(0.001, 1000.0))
+ .addGrid(lr.maxIter, Array(0, 10))
+ .build()
+ val eval = new BinaryClassificationEvaluator
+ val cv = new CrossValidator()
+ .setEstimator(lr)
+ .setEstimatorParamMaps(lrParamMaps)
+ .setEvaluator(eval)
+ .setNumFolds(3)
+ val model = cv.fit(dataset)
+ MLTestingUtils.checkCopy(model)
--- End diff --
Put in an earlier test where the model is fit().
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
