Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/8111#issuecomment-130197330
Review status: 78 of 132 files reviewed at latest revision, 12 unresolved
discussions, all commit checks successful.
---
<sup>**[sql/core/src/test/scala/org/apache/spark/sql/sources/FilteredScanSuite.scala,
line 104
\[r8\]](https://reviewable.io:443/reviews/apache/spark/8111#-JwUYyv5Rn0y2FBExvmG)**
([raw
file](https://github.com/apache/spark/blob/e1e513e0af646588cdceaa6abc75487025247aaf/sql/core/src/test/scala/org/apache/spark/sql/sources/FilteredScanSuite.scala#L104)):</sup>
By the way, not all of these are straightforward to convert. E.g. JDBCSuite
has a ton of stuff in before { }. Do you think it makes sense to call an
"ensureContextInitialized" in before { } in those cases? Or is it fine if tests
pass? I ran JDBCSuite locally and it passes...
---
Comments from the [review on
Reviewable.io](https://reviewable.io:443/reviews/apache/spark/8111)
<!-- Sent from Reviewable.io -->
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
