Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/8111#issuecomment-130201675
Reviewed 4 of 22 files at r9.
Review status: 68 of 133 files reviewed at latest revision, 1 unresolved
discussion, all commit checks successful.
---
<sup>**[sql/core/src/test/scala/org/apache/spark/sql/sources/FilteredScanSuite.scala,
line 104
\[r8\]](https://reviewable.io:443/reviews/apache/spark/8111#-JwUYyv5Rn0y2FBExvmG)**
([raw
file](https://github.com/apache/spark/blob/e1e513e0af646588cdceaa6abc75487025247aaf/sql/core/src/test/scala/org/apache/spark/sql/sources/FilteredScanSuite.scala#L104)):</sup>
Both `before` and `beforeAll()` are still run before each individual test,
so unless I'm overlooking something I don't think this is going to change test
behavior. My suggestion here was mostly for clarity. I think we can just defer
this cleanup until later, since fixing all of them at once is going to take a
while.
---
Comments from the [review on
Reviewable.io](https://reviewable.io:443/reviews/apache/spark/8111)
<!-- Sent from Reviewable.io -->
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
