Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8007#discussion_r36935482
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
    @@ -718,7 +721,7 @@ private[spark] class TaskSetManager(
           put(info.executorId, clock.getTimeMillis())
         sched.dagScheduler.taskEnded(tasks(index), reason, null, null, info, 
taskMetrics)
         addPendingTask(index)
    -    if (!isZombie && state != TaskState.KILLED && 
!reason.isInstanceOf[TaskCommitDenied]) {
    +    if (!isZombie && state != TaskState.KILLED && 
shouldTaskFailureEventuallyFailJob(reason)) {
           // If a task failed because its attempt to commit was denied, do not 
count this failure
           // towards failing the stage. This is intended to prevent spurious 
stage failures in cases
           // where many speculative tasks are launched and denied to commit.
    --- End diff --
    
    this comment should go into the java doc of your new method


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to