Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8007#discussion_r36936239
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
 ---
    @@ -91,6 +92,51 @@ private[spark] abstract class YarnSchedulerBackend(
       }
     
       /**
    +   * Override the DriverEndpoint to add extra logic for the case when an 
executor is disconnected.
    +   * We should check the cluster manager and find if the loss of the 
executor was caused by YARN
    +   * force killing it due to preemption.
    +   */
    +  private class YarnDriverEndpoint(rpcEnv: RpcEnv, sparkProperties: 
ArrayBuffer[(String, String)])
    +      extends DriverEndpoint(rpcEnv, sparkProperties) {
    +
    +    private val pendingDisconnectedExecutors = new HashSet[String]
    +    private val handleDisconnectedExecutorThreadPool =
    +      
ThreadUtils.newDaemonCachedThreadPool("yarn-driver-handle-lost-executor-thread-pool")
    +
    +    override def onDisconnected(rpcAddress: RpcAddress): Unit = {
    --- End diff --
    
    need a huge java doc to explain what your'e doing here and why


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to