Github user dragos commented on a diff in the pull request:
https://github.com/apache/spark/pull/8199#discussion_r37072960
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/rate/PIDRateEstimator.scala
---
@@ -39,13 +41,17 @@ package org.apache.spark.streaming.scheduler.rate
* of future errors, based on current rate of change. This value
should be positive or 0.
* This term is not used very often, as it impacts stability of the
system. The default
* value is 0.
+ * @param minRate what is the minimum rate that can be estimated.
+ * This must be more than zero, so that the system always receives
so data for rate
--- End diff --
nit: "greater than zero" sounds nicer. Also, "receives so data for rate"
seems a typo, probably "some data"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
