Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7052#discussion_r37812058
  
    --- Diff: core/src/test/resources/log4j.properties ---
    @@ -16,13 +16,19 @@
     #
     
     # Set everything to be logged to the file target/unit-tests.log
    -log4j.rootCategory=INFO, file
    +test.appender=file
    +log4j.rootCategory=INFO, ${test.appender}
     log4j.appender.file=org.apache.log4j.FileAppender
     log4j.appender.file.append=true
     log4j.appender.file.file=target/unit-tests.log
     log4j.appender.file.layout=org.apache.log4j.PatternLayout
     log4j.appender.file.layout.ConversionPattern=%d{yy/MM/dd HH:mm:ss.SSS} %t 
%p %c{1}: %m%n
     
    +log4j.appender.console=org.apache.log4j.ConsoleAppender
    +log4j.appender.console.target=System.err
    +log4j.appender.console.layout=org.apache.log4j.PatternLayout
    +log4j.appender.console.layout.ConversionPattern=%t: %m%n
    +
    --- End diff --
    
    mean to be merged?  If we really do want this in here, should probably add 
a brief comment that developers can use this by configuring `test.appender`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to