Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7052#discussion_r37815327
--- Diff:
yarn/src/test/scala/org/apache/spark/deploy/yarn/BaseYarnClusterSuite.scala ---
@@ -144,7 +146,12 @@ abstract class BaseYarnClusterSuite
extraConf.foreach { case (k, v) => props.setProperty(k, v) }
- val propsFile = File.createTempFile("spark", ".properties", tempDir)
+ val submitConf = extraConf ++ Map(
+ // SPARK-4267: make sure java options are propagated correctly.
+ "spark.driver.extraJavaOptions" -> "-Dfoo=\"one two three\"",
+ "spark.executor.extraJavaOptions" -> "-Dfoo=\"one two three\"")
+
+ val propsFile = createConfFile(childClasspath = childClasspath,
extraConf = submitConf)
val writer = new OutputStreamWriter(new FileOutputStream(propsFile),
UTF_8)
props.store(writer, "Spark properties.")
--- End diff --
I'm confused -- those props related to SPARK-4267 are already set above on
line 132, and then they are written to the file here. It looks like you are
ignoring `props` when initially writing the file w/ `createConfFile`, but then
overwriting it again with this call to `props.store`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
