Github user markhamstra commented on the pull request:
https://github.com/apache/spark/pull/7699#issuecomment-134690926
This LGTM. The only issues I have are quibbles, such as that the
formatting of `runEvent(CompletionEvent ... )` isn't consistent in
DAGSchedulerSuite and I find the style in, e.g., "extremely late fetch failures
don't cause multiple concurrent attempts for the same stage" easier to read
than in "don't submit stage until its dependencies map outputs are registered
(SPARK-5259)"; or that I'd prefer that the `partitions.size` calls in the test
be `partitions.length` (not a meaningful performance optimization in this
context, but it would make my IDE happier.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
