Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1090#discussion_r13819928
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/SortedParitionsRDD.scala 
---
    @@ -0,0 +1,337 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.rdd
    +
    +import scala.reflect.ClassTag
    +import scala.collection.mutable.ArrayBuffer
    +import java.io.{InputStream, BufferedInputStream, FileInputStream, File, 
Serializable, EOFException}
    +import org.apache.spark.{Partition, TaskContext}
    +import org.apache.spark.{Logging, SparkEnv}
    +import org.apache.spark.serializer.Serializer
    +import org.apache.spark.storage.{BlockId, BlockManager}
    +import org.apache.spark.util.SizeEstimator
    +
    +/**
    + * An RDD that sorts each of it's partitions independently.
    + * 
    + * If partitions are too large to fit in memory, they are externally 
sorted.
    + * 
    + * Two parameters control the memory threshold for external sort:
    + *
    + *   `spark.shuffle.memoryFraction` specifies the collective amount of 
memory used for storing
    --- End diff --
    
    If we use the same parameter for sorting, it might make sense to call this 
something else, since this isn't exactly a shuffle.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to