Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/1090#issuecomment-46214599
Hi @msiddalingaiah, thanks for adding this much-needed functionality. I
haven't looked too closely into the details, but it seems that this shares much
of the logic (and code, in some cases) with the ExternalAppendOnlyMap. It would
be good if this is integrated somehow with the map.
One possibility is to just use the ExternalAppendOnlyMap as your underlying
buffer, and use the array index as the key and the actual value as the
combiner. I haven't explored fully myself whether this is possible with the
current code, but it would be super cool if it works out. If there is no easy
way to do this, we should at least abstract out the common logic as helper
methods in Utils.scala or something.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
